Fix: Ensure helpfulSearchDiv hides consistently on context menu#4276
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Jan 15, 2025
Merged
Fix: Ensure helpfulSearchDiv hides consistently on context menu#4276walterbender merged 1 commit intosugarlabs:masterfrom
walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
Ubayed-Bin-Sufian
pushed a commit
to Ubayed-Bin-Sufian/musicblocks
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4275
What does this PR do?
This pull request fixes an issue where the helpfulSearchDiv widget does not hide consistently when the context menu is triggered on the canvas. This ensures a cleaner UI and a better user experience.
Key changes
Added a check while opening do context menu to ensure if the helpfulSearchWidget is on, it closes before opening the menu, the method being already defined as _hideHelpfulSearchDiv
###Screenshots
Screencast from 15-01-25 03:05:23 PM IST.webm
special thanks @haroon10725 and @walterbender for pointing out the bug